Skip to content

Update README.md #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update README.md #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ Due to security, when installed this way the Magento standard for phpcs cannot b
You can achieve this by adding the following to your project's `composer.json`:
````
"scripts": {
"post-install-cmd": [
"([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/)"
"post-install-cmd": [
"( [ -f vendor/bin/phpcs ] && [ -L vendor/bin/phpcs ] && vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/) || true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please investigate the possibility to avoid the use of || true here?
],
"post-update-cmd": [
"([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/)"
"( [ -f vendor/bin/phpcs ] && [ -L vendor/bin/phpcs ] && vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/) || true"
]
}
````
Expand Down