Update README.md #133
Closed
Update README.md #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In composer Composer 1.9.0 2019-08-02 20:55:32 the env variable COMPOSER_DEV_MODE got been removed for post events. Please see the difference of the [post](https://github.com/composer/composer/blob/96ad0aa01fa49a39539c089ca4a1aa1a54cba98d/src/Composer/Installer.php#L321) and [pre](https://github.com/composer/composer/blob/96ad0aa01fa49a39539c089ca4a1aa1a54cba98d/src/Composer/Installer.php#L199) hooks. This happend [in this commit](composer/composer@4c4f516#diff-74425bc790838a69d0d16f06fc313edb)
lenaorobei reviewed Aug 23, 2019
| "post-install-cmd": [ | ||
| "([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/)" | ||
| "post-install-cmd": [ | ||
| "( [ -f vendor/bin/phpcs ] && [ -L vendor/bin/phpcs ] && vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/) || true" |
There was a problem hiding this comment.
Could you please investigate the possibility to avoid the use of || true here?
| @dng-dev closing this PR due to inactivity. Please feel free to reopen if you are planning to continue working on it. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In composer Composer 1.9.0 2019-08-02 20:55:32 the env variable COMPOSER_DEV_MODE got been removed for post events. Please see the difference of the post and pre
hooks.
This happend in this commit