Skip to content

feat(postgresql): add support for multiple insert in one query using createAll() of connector #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2022
Merged

feat(postgresql): add support for multiple insert in one query using createAll() of connector #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/postgresql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ PostgreSQL.prototype.getDefaultSchemaName = function() {
return 'public';
};

PostgreSQL.prototype.multiInsertSupported = true;

/**
* Connect to PostgreSQL
* @callback {Function} [callback] The callback after the connection is established
Expand Down Expand Up @@ -591,6 +593,15 @@ PostgreSQL.prototype.getInsertedId = function(model, info) {
return idValue;
};

PostgreSQL.prototype.getInsertedIds = function(model, info) {
const idColName = this.idColumn(model);
let idValues;
if (info && Array.isArray(info)) {
idValues = info.map((data) => data[idColName]);
}
return idValues;
};

/**
* Build the SQL WHERE clause for the where object
* @param {string} model Model name
Expand Down
113 changes: 76 additions & 37 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "IBM Corp.",
"repository": "github:loopbackio/loopback-connector-postgresql",
"engines": {
"node": ">=10"
"node": "14 || 16 || 18"
},
"scripts": {
"pretest": "node pretest.js",
Expand All @@ -33,7 +33,7 @@
"bluebird": "^3.4.6",
"chalk": "^4.0.0",
"debug": "^4.1.1",
"loopback-connector": "^5.0.0",
"loopback-connector": "^5.1.1",
"pg": "^8.0.2",
"strong-globalize": "^6.0.0",
"uuid": "^9.0.0"
Expand All @@ -46,7 +46,7 @@
"juggler-v3": "file:./deps/juggler-v3",
"juggler-v4": "file:./deps/juggler-v4",
"lodash": "^4.17.4",
"loopback-datasource-juggler": "^3.0.0 || ^4.0.0",
"loopback-datasource-juggler": "^4.28.0",
Copy link
Member

@dhmlau dhmlau Nov 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, though loopback-datasource-juggle@3.x reaches EOL. Together with the discussion in #520, it might be a good time to do it.

@loopbackio/loopback-maintainers, thoughts?
Copy link
Contributor Author

@samarpanB samarpanB Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes its a breaking change. So I agree to go ahead with it.
Copy link
Member

@achrinza achrinza Nov 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for making a breaking change
Copy link
Contributor Author

@samarpanB samarpanB Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
"mocha": "^10.0.0",
"rc": "^1.0.0",
"should": "^13.2.3",
Expand Down
5 changes: 4 additions & 1 deletion pretest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ process.env.PGPASSWORD = process.env.TEST_POSTGRESQL_PASSWORD ||
process.env.POSTGRESQL_PASSWORD || process.env.PGPASSWORD || 'test';

console.log('seeding DB with test db...');
const psql = cp.spawn('psql', {stdio: stdio});
const args = process.env.POSTGRESQL_DATABASE ?
['-U', process.env.PGUSER, process.env.POSTGRESQL_DATABASE] :
['-U', process.env.PGUSER];
const psql = cp.spawn('psql', args, {stdio: stdio});
sql.pipe(psql.stdin);
psql.on('exit', function(code) {
console.log('done seeding DB');
Expand Down
Loading