feat(postgresql): add support for multiple insert in one query using createAll() of connector #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
samarpanB requested review from achrinza, dhmlau and marioestradarosa as code owners samarpanB force-pushed the gh-523 branch 2 times, most recently from 8fb334d to 8cfd15b Compare 
dhmlau reviewed Nov 17, 2022
| "juggler-v4": "file:./deps/juggler-v4", | ||
| "lodash": "^4.17.4", | ||
| "loopback-datasource-juggler": "^3.0.0 || ^4.0.0", | ||
| "loopback-datasource-juggler": "^4.28.0", |
Member
There was a problem hiding this comment.
This is a breaking change, though loopback-datasource-juggle@3.x reaches EOL. Together with the discussion in #520, it might be a good time to do it.
@loopbackio/loopback-maintainers, thoughts?
Contributor Author
There was a problem hiding this comment.
Yes its a breaking change. So I agree to go ahead with it.
Member
There was a problem hiding this comment.
+1 for making a breaking change
…createAll() of connector BREAKING CHANGE: This drops explicit, documented support for Node.js v10, v11, v12, v13, v15, v17 Signed-off-by: Samarpan Bhattacharya <this.is.samy@gmail.com>
dhmlau approved these changes Nov 22, 2022
Member
dhmlau left a comment
dhmlau left a comment There was a problem hiding this comment.
LGTM. Please make sure CI passes before merging. Thanks.
Contributor Author
| All checks passing. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This drops explicit, documented support for Node.js v10, v11, v12, v13, v15, v17
Signed-off-by: Samarpan Bhattacharya this.is.samy@gmail.com
Fixes #523
See also loopbackio/loopback-next#3357
Checklist
npm testpasses on your machine