Add docker setup #256
Merged
Add docker setup #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add a setup script that spawns a docker container before running test Easy for contributors now to test, no need for a local instance
Currently, it sets the config if we set CI=true
Only seed the database if user specifies CI=true OR when the tests actually run on the CI
ssh24 force-pushed the add-docker-setup branch 2 times, most recently from 3473629 to 6c5d032 Compare 
dhmlau requested changes May 12, 2017
| 2. Under Login Roles, add a user called ```strongloop```. | ||
| | ||
| __Change configuration for database connection__ | ||
| ## Running tests |
There was a problem hiding this comment.
is there any reason we remove the info about how to run the tests locally without docker?
There was a problem hiding this comment.
CI=true pre seeds the database. We do not need to do any additional configuration.
dhmlau approved these changes May 12, 2017
kjdelisle pushed a commit that referenced this pull request May 15, 2017
* Add docker setup (#256) (Sakib Hasan) * Allow explicit numeric datatype (#254) (Sakib Hasan) * Allow non-id serial properties (#198) (zbarbuto) * Revert PR #246 (#248) (Sakib Hasan) * Add loopback-connector as peer dependencies (#246) (Russ Tyndall) * Fix operations on ended transactions (zbarbuto) * dbdefaults: Cleanup InvalidDefault def after test (Kevin Delisle) * Reuse the data source to avoid too many clients (Raymond Feng)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
connect to https://github.com/strongloop-internal/scrum-apex/issues/216