Allow non-id serial properties #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
| Can one of the admins verify this patch? |
2 similar comments
| Can one of the admins verify this patch? |
| Can one of the admins verify this patch? |
| @zbarbuto could you please add some unit tests to go with your PR? |
| @zbarbuto Any updates on adding unit tests with this patch? |
| Yes. Hope to look at this soon. |
| Looking at this now. |
zbarbuto force-pushed the non-id-serial-props branch from a9b0dad to be13ad5 Compare | @ssh24 Test added and rebased off master. Sorry for the delay. |
zbarbuto force-pushed the non-id-serial-props branch from be13ad5 to aa27031 Compare | @slnode test please |
ssh24 force-pushed the non-id-serial-props branch from aa27031 to 62d146f Compare | @slnode test please |
ssh24 reviewed Apr 19, 2017
test/postgresql.test.js Outdated
| }, | ||
| }; | ||
| var models = db.modelBuilder.buildModels(schema); | ||
| // console.log(models); |
There was a problem hiding this comment.
Please remove the uncommented code.
kjdelisle pushed a commit that referenced this pull request May 15, 2017
* Add docker setup (#256) (Sakib Hasan) * Allow explicit numeric datatype (#254) (Sakib Hasan) * Allow non-id serial properties (#198) (zbarbuto) * Revert PR #246 (#248) (Sakib Hasan) * Add loopback-connector as peer dependencies (#246) (Russ Tyndall) * Fix operations on ended transactions (zbarbuto) * dbdefaults: Cleanup InvalidDefault def after test (Kevin Delisle) * Reuse the data source to avoid too many clients (Raymond Feng)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Allow properties that are not an ID to be created as
SERIAL.Example use-case: Using GUIDs for a primary id key but still want an auto-incrementing counter value
Related issues
Checklist
guide