Skip to content

Conversation

@antonkomarev
Copy link
Contributor

Migrator class has dynamic $this->notes property, which not using.
It looks like legacy code because there is note method, but it uses $this->output to write notes.

protected function note($message) { if ($this->output) { $this->output->writeln($message); } }
@staudenmeir
Copy link
Contributor

#24811 forgot to remove the property.

@antonkomarev
Copy link
Contributor Author

@staudenmeir, thanks for the link!

@taylorotwell taylorotwell merged commit 2f7d011 into laravel:5.8 Jun 4, 2019
@antonkomarev antonkomarev deleted the remove/unused-migrator-dynamic-property branch June 4, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants