[5.7] Display messages during running migrator #24811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
At the moment all messages during running migrations are put into
notesproperty and displayed AFTER running migrations.However it's not very helpful in case of running a lot of migrations or in case of running migrations that take a lot of time. At the moment in such case you need to open database and take look at
migrationstable to see that new migrations appeared in there.If approved after the change you will see right away what migration is running right now and in case of multiple migrations you will then see that migrations are really running and not get stuck in single migration for minutes.