- Notifications
You must be signed in to change notification settings - Fork 1.2k
✨ setup-envtest: download binaries from controller-tools releases #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot merged 2 commits into kubernetes-sigs:main from sbueringer:pr-setup-envtest-ct-rel May 22, 2024
Merged
✨ setup-envtest: download binaries from controller-tools releases #2811
k8s-ci-robot merged 2 commits into kubernetes-sigs:main from sbueringer:pr-setup-envtest-ct-rel May 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
9f723df
to 376fd6e
Compare /assign @vincepri @alvaroaleman /cc @chrischdi @fabriziopandini (fyi) |
sbueringer commented May 6, 2024
/hold Want to create a few more envtest binary archives via controller-tools releases after this PR is approved and before it is merged |
vincepri reviewed May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a lot !!!
It seems great
376fd6e
to 6459f05
Compare Sorry for the push force. Forgot to push a few small improvements before |
6 tasks
5 tasks
This was referenced May 23, 2024
This was referenced May 29, 2024
Merged
damdo added a commit to damdo/cluster-api-provider-aws that referenced this pull request May 30, 2024
This is a commit from CR main (22.05.2024). Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811 Please enter the commit message for your changes. Lines starting with '#' will be ignored, and an empty message aborts the commit.
damdo added a commit to damdo/cluster-api-provider-gcp-1 that referenced this pull request May 30, 2024
This is a commit from CR main (22.05.2024). Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/cluster-api-provider-gcp that referenced this pull request May 30, 2024
This is a commit from CR main (22.05.2024). Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811
This was referenced May 31, 2024
damdo added a commit to damdo/cluster-api-provider-aws that referenced this pull request May 31, 2024
This is a commit from CR main (22.05.2024). Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811 Please enter the commit message for your changes. Lines starting with '#' will be ignored, and an empty message aborts the commit.
damdo added a commit to damdo/cluster-api-provider-gcp that referenced this pull request Jun 4, 2024
This is a commit from CR main (22.05.2024). Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811
r4f4 added a commit to r4f4/installer that referenced this pull request Jun 6, 2024
r4f4 added a commit to r4f4/installer that referenced this pull request Jun 6, 2024
To align with kubernetes-sigs/controller-runtime#2811. Also we now have access to the same version we use in the release which is 1.29.5.
jas-nik pushed a commit to jas-nik/cluster-api-provider-aws that referenced this pull request Jun 26, 2024
This is a commit from CR main (22.05.2024). Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811 Please enter the commit message for your changes. Lines starting with '#' will be ignored, and an empty message aborts the commit.
fad3t pushed a commit to fad3t/cluster-api-provider-aws that referenced this pull request Jul 25, 2024
This is a commit from CR main (22.05.2024). Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811 Please enter the commit message for your changes. Lines starting with '#' will be ignored, and an empty message aborts the commit.
This was referenced Aug 15, 2024
fad3t pushed a commit to fad3t/cluster-api-provider-aws that referenced this pull request Oct 8, 2024
This is a commit from CR main (22.05.2024). Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811 Please enter the commit message for your changes. Lines starting with '#' will be ignored, and an empty message aborts the commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
setup-envtest today downloads archives with envtest binaries from the kubebuilder GCS bucket. Given kubernetes/k8s.io#2647 we have to ASAP move away from this.
@vincepri and I tried and discussed various options (GitHub packages, k8s staging GCS bucket & registry, k8s prod registry) and we eventually ended up with publishing envtest binaries to controller-tools releases. The reason was that this is the only supported place to host artifacts in the k8s ecosystem for us:
So our new envtest binary archive "repository" looks like this:
This PR now extends setup-envtest so that it can download envtest archives from the controller-tools repo. This is also the new default. This PR also deprecates the functionality to download from the kubebuilder bucket or from GCS buckets in general. We anticipate that this will be removed with v0.19 or v0.20. We only keep it around for now as a fallback option.
The UX looks like this:
--index
can be used--use-deprecated-gcs
can be used (for now, until either the flag is removed or the bucket goes down, whatever comes first)TBD how we backport this. My initial idea would be to backport it to release-0.17 with
--use-deprecated-gcs
enabled per default (I don't want to change the behavior in a patch version of setup-envtest)I did the following manual testing:
Additional infos:
Old
New
Testing this via this PR in CAPI: kubernetes-sigs/cluster-api#10569