🌱 Bump setup-envtest to use new controller-tools binaries #4996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
k8s-ci-robot added release-note-none k8s-ci-robot added size/S 
| /hold |
k8s-ci-robot added the do-not-merge/hold 
damdo force-pushed the bump-setup-envtest branch 2 times, most recently from 0cfa3d6 to e4def3c Compare k8s-ci-robot added size/M damdo changed the title | /unhold /assign @nrb |
k8s-ci-robot removed the do-not-merge/hold 
nrb reviewed May 31, 2024
This is a commit from CR main (22.05.2024). Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811 Please enter the commit message for your changes. Lines starting with '#' will be ignored, and an empty message aborts the commit.
| @nrb should be ready for labelling. |
| /lgtm |
k8s-ci-robot added the lgtm 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nrb The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot added the approved | /retest |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This was brought up in the weekly CAPI community meeting.
This is a commit from CR main (22.05.2024).
Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811
Release note:
TODO:
hack/toolstoo once this is addressed: [release-0.18] ✨ setup-envtest: download binaries from controller-tools releases controller-runtime#2837 (comment)