Skip to content

Conversation

@riyueguang
Copy link
Contributor

@riyueguang riyueguang commented Apr 12, 2025

  • PR Description
    fix function name in comment

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc
@riyueguang
Copy link
Contributor Author

friendly ping

@stefanhaller
Copy link
Collaborator

Thanks; please rebase onto master and resolve conflicts, and I'll merge.

Long-term I'd rather like to remove the function names from the comments altogether, this would avoid this class of problem.

Signed-off-by: riyueguang <rustruby@outlook.com>
@riyueguang
Copy link
Contributor Author

@stefanhaller Thank you for your reply.

I have resolved the conflicts and rebased with the latest code.

Please review it again.

@stefanhaller stefanhaller added the maintenance For refactorings, CI changes, tests, version bumping, etc label Dec 6, 2025
@stefanhaller stefanhaller merged commit 0fc8cb3 into jesseduffield:master Dec 6, 2025
12 of 13 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 12, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [jesseduffield/lazygit](https://github.com/jesseduffield/lazygit) | minor | `v0.56.0` -> `v0.57.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jesseduffield/lazygit (jesseduffield/lazygit)</summary> ### [`v0.57.0`](https://github.com/jesseduffield/lazygit/releases/tag/v0.57.0) [Compare Source](jesseduffield/lazygit@v0.56.0...v0.57.0) <!-- Release notes generated using configuration in .github/release.yml at v0.57.0 --> #### What's Changed ##### Enhancements 🔥 - Open pull requests in browser with extra leading slashes removed by [@&#8203;hrzlgnm](https://github.com/hrzlgnm) in [#&#8203;5018](jesseduffield/lazygit#5018) - Allow using SelectedSubmodule in CustomCommands by [@&#8203;rlkandela](https://github.com/rlkandela) in [#&#8203;5015](jesseduffield/lazygit#5015) - Don't allow empty input in most prompts by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5043](jesseduffield/lazygit#5043) - Suppress output from background fetch (unless there were errors) by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5044](jesseduffield/lazygit#5044) - feat: add fork remote command by [@&#8203;karolzwolak](https://github.com/karolzwolak) in [#&#8203;4831](jesseduffield/lazygit#4831) - Trigger immediate background fetch when switching repos by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5047](jesseduffield/lazygit#5047) ##### Fixes 🔧 - Keep cursor at top/bottom when navigating by page by [@&#8203;RaphaeleL](https://github.com/RaphaeleL) in [#&#8203;5019](jesseduffield/lazygit#5019) - Switch to branches view when checking out a commit by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5048](jesseduffield/lazygit#5048) - Fix deleting a remote tag when a remote branch with the same name exists, or vice versa by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5075](jesseduffield/lazygit#5075) - Show fixup base commits in correct order in ctrl-f error message by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5073](jesseduffield/lazygit#5073) - Band-aid fix for rare crashes when refreshing files by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5074](jesseduffield/lazygit#5074) - Fix to support creating MRs for repositories cloned with SSH alias by [@&#8203;roveo](https://github.com/roveo) in [#&#8203;5082](jesseduffield/lazygit#5082) ##### Maintenance ⚙️ - Keep config and schema unchanged during a release by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5010](jesseduffield/lazygit#5010) - Modernize all codes by [@&#8203;phanen](https://github.com/phanen) in [#&#8203;5036](jesseduffield/lazygit#5036) - Bump golang.org/x/crypto from 0.37.0 to 0.45.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5054](jesseduffield/lazygit#5054) - Don't use "HEADLESS" environment variable for running tests by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5064](jesseduffield/lazygit#5064) - refactor: use strings.Builder and strings.Repeat to simplify code by [@&#8203;boqishan](https://github.com/boqishan) in [#&#8203;5068](jesseduffield/lazygit#5068) - chore: fix function name in comment by [@&#8203;riyueguang](https://github.com/riyueguang) in [#&#8203;4481](jesseduffield/lazygit#4481) ##### Docs 📖 - Add a "Commit history" section to CONTRIBUTING.md by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5022](jesseduffield/lazygit#5022) - Update table of contents in README.md by [@&#8203;madscientist16](https://github.com/madscientist16) in [#&#8203;5045](jesseduffield/lazygit#5045) - Update docs and schema for release by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5091](jesseduffield/lazygit#5091) ##### I18n 🌎 - Update translations from Crowdin by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5090](jesseduffield/lazygit#5090) ##### Performance Improvements 📊 - Fix and speed up the file list for the "Enter path to filter by" feature by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5056](jesseduffield/lazygit#5056) #### New Contributors - [@&#8203;hrzlgnm](https://github.com/hrzlgnm) made their first contribution in [#&#8203;5018](jesseduffield/lazygit#5018) - [@&#8203;RaphaeleL](https://github.com/RaphaeleL) made their first contribution in [#&#8203;5019](jesseduffield/lazygit#5019) - [@&#8203;rlkandela](https://github.com/rlkandela) made their first contribution in [#&#8203;5015](jesseduffield/lazygit#5015) - [@&#8203;phanen](https://github.com/phanen) made their first contribution in [#&#8203;5036](jesseduffield/lazygit#5036) - [@&#8203;madscientist16](https://github.com/madscientist16) made their first contribution in [#&#8203;5045](jesseduffield/lazygit#5045) - [@&#8203;karolzwolak](https://github.com/karolzwolak) made their first contribution in [#&#8203;4831](jesseduffield/lazygit#4831) - [@&#8203;boqishan](https://github.com/boqishan) made their first contribution in [#&#8203;5068](jesseduffield/lazygit#5068) - [@&#8203;riyueguang](https://github.com/riyueguang) made their first contribution in [#&#8203;4481](jesseduffield/lazygit#4481) - [@&#8203;roveo](https://github.com/roveo) made their first contribution in [#&#8203;5082](jesseduffield/lazygit#5082) **Full Changelog**: <jesseduffield/lazygit@v0.56.0...v0.57.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi40Ny4wIiwidXBkYXRlZEluVmVyIjoiNDIuNDcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance For refactorings, CI changes, tests, version bumping, etc

2 participants