Fix and speed up the file list for the "Enter path to filter by" feature #5056
+63 −3,318
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The file suggestions list that appears when you choose "Enter path to filter by" from the Filtering menu was previously implemented by walking the file system to collect all files, and then filter out the ones that are git-ignored. This approach had several problems:
This PR improves all these by using a call to
git ls-filesto list the repositories files.Here are some rough hand-timed measurements (from opening the Filtering dialog until the file list shows) for various repos:
Fixes #2642