Skip to content

Conversation

@pdobacz
Copy link
Member

@pdobacz pdobacz commented Feb 27, 2025

Update with ipsilon/eof#156, planned for EOF Osaka-devnet-1. EOFCREATE stack args order to match that of EXT*CALL.

The change in EEST which goes in hand with this: ethereum/execution-spec-tests#1274

@pdobacz pdobacz self-assigned this Feb 27, 2025
@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (f1736a1) to head (c20f3eb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #1147 +/- ## ========================================== - Coverage 94.48% 94.48% -0.01%  ========================================== Files 170 170 Lines 18027 18026 -1 ========================================== - Hits 17033 17032 -1  Misses 994 994 
Flag Coverage Δ
eof_execution_spec_tests 20.66% <0.00%> (+<0.01%) ⬆️
ethereum_tests 26.93% <0.00%> (+<0.01%) ⬆️
ethereum_tests_silkpre 19.50% <0.00%> (+<0.01%) ⬆️
execution_spec_tests 21.29% <0.00%> (+<0.01%) ⬆️
unittests 91.78% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone/instructions_calls.cpp 98.72% <100.00%> (ø)
test/unittests/eof_example_test.cpp 100.00% <ø> (ø)
test/utils/bytecode.hpp 97.34% <100.00%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@pdobacz pdobacz force-pushed the eofcreate-stack-order branch from d0eb9c0 to 32cced7 Compare April 7, 2025 17:31
@pdobacz pdobacz marked this pull request as ready for review April 8, 2025 06:31
@pdobacz pdobacz requested a review from gumb0 April 8, 2025 07:15
@pdobacz pdobacz force-pushed the eofcreate-stack-order branch from 32cced7 to 1242dae Compare April 8, 2025 08:39
@pdobacz pdobacz force-pushed the eofcreate-stack-order branch from 1242dae to c20f3eb Compare April 8, 2025 08:40
@pdobacz pdobacz merged commit 53866c1 into master Apr 8, 2025
25 checks passed
@pdobacz pdobacz deleted the eofcreate-stack-order branch April 8, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants