Align EOFCREATE stack args with EXTCALL #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
5 tasks
This was referenced Feb 27, 2025
gumb0 approved these changes Apr 4, 2025
pdobacz force-pushed the reorder-eofcreate-stack branch from 9f0757c to 453fdb7 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It has been brought to attention in https://ethereum-magicians.org/t/eip-7620-eof-contract-creation-instructions/18625/4 that the stack args of EOFCREATE do not align with CREATE2. This is something good, since args of those opcodes have unintuitively distinct meaning - namely the input buffer.
However we seem to be missing out on an opportunity to align the EOFCREATE stack args with another closely related opcode: EXTCALL. They differ only by a single argument (
saltvstarget_address) per EIP-7069, so we could aim to make them aligned.