Skip to content

Conversation

@Yenniferh
Copy link
Contributor

@Yenniferh Yenniferh commented Oct 8, 2023

Translates the Singleton Pattern to Spanish

Task of #2277

Copy link
Contributor

@miguel-is-coding miguel-is-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found one need to change in line 4. The other changes requested are regarding to translations according to the context.

Thanks for your time!

---
title: Singleton
category: Creational
language: en
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change language here to es, like this:

language: es 
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

- Gang of Four
---

## Intención
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this context, I think is better to use Propósito instead of Intención, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

> Solo puede haber una torre de marfil donde los magos estudian su magia. La misma torre de marfil encantada
> siempre es utilizada por los magos. La torre de marfil aquí es un singleton.

En palabras simples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, for the context, I think it fits better En otras palabras

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Yenniferh
Copy link
Contributor Author

Thanks for your suggestions, @miguel-is-coding. All were implemented.

Copy link
Contributor

@miguel-is-coding miguel-is-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miguel-is-coding
Copy link
Contributor

@iluwatar who should be assigned to review and approve this? thanks

@iluwatar iluwatar merged commit 4654288 into iluwatar:master Oct 25, 2023
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @miguel-is-coding for review

@allcontributors
Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @miguel-is-coding! 🎉

sugan0tech pushed a commit to sugan0tech/java-design-patterns that referenced this pull request Nov 12, 2023
…r#2627) * Translates Singleton Pattern to Spanish for iluwatar#2277 * Fixes the class diagram path * ADD: Suggested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants