correct tests recently modified or introduced #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
flavorjones added a commit to sparklemotion/nokogiri that referenced this pull request Apr 7, 2023
which is upstream at html5lib/html5lib-tests#165
gsnedders reviewed Apr 11, 2023
gsnedders added a commit to gsnedders/web-platform-tests that referenced this pull request Apr 11, 2023
When innerHTML is applied to a template, it uses the template's template contents as its context object, which means we need to serialize that and not the element itself. See also html5lib/html5lib-tests#165
gsnedders added a commit to web-platform-tests/wpt that referenced this pull request Apr 11, 2023
When innerHTML is applied to a template, it uses the template's template contents as its context object, which means we need to serialize that and not the element itself. See also html5lib/html5lib-tests#165
and revert a template test change from 1314b09
flavorjones force-pushed the flavorjones-fix-template-2023-04 branch from 38b11e5 to f28ed37 Compare 
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 15, 2023
…cument-fragment: template, a=testonly Automatic update from web-platform-tests Fix html5lib test serialization with #document-fragment: template When innerHTML is applied to a template, it uses the template's template contents as its context object, which means we need to serialize that and not the element itself. See also html5lib/html5lib-tests#165 -- wpt-commits: ff2fcb22027c36f71122179189800392ac906d12 wpt-pr: 39474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some of the tests recently introduced or modified need to be corrected.
Specific changes are:
#errorsfor the testsThese tests were caught by Nokogiri's libgumbo test suite, which was proposed as a downstream test in #154.