Fix template not having surrounding document #161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
html5lib#158 removed the fragment mode, without updating the expected document.
Contributor Author
| There will also be a number of errors that come up, but that I don't check for — might be easier to revert the commit. Also this makes a good case for downstream tests. |
Contributor
| cc @annevk |
Contributor
| @fb55 hmm, does that mean we should revert my fix or was there something wrong, but my fix was incomplete? |
Contributor Author
| Template tags are allowed within other template tags, so the previous test was valid as it was. I would lean towards reverting the commit. |
Contributor
| https://wpt.fyi/results/html/syntax/parsing/html5lib_innerHTML_template.html is what made me think the test was bogus in some way. |
Contributor Author
| Closing in favor of #165 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#158 removed the fragment mode, without updating the expected document.
Originated in inikulin/parse5#877.