Skip to content

Update custom setup script for Cabal-2.0 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Update custom setup script for Cabal-2.0 #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions HsOpenSSL.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ Flag macports-openssl
Default:
False

Custom-setup
setup-depends: Cabal >=1.12 && <2.1,
base >=4.4 && <5

Library
Build-Depends:
base >= 4.4 && < 5,
Expand Down
15 changes: 9 additions & 6 deletions Setup.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
{-# LANGUAGE CPP #-}
{-# LANGUAGE TupleSections #-}

#ifndef MIN_VERSION_Cabal
Copy link
Contributor

@hvr hvr Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in case this doesn't seem obvious: the trick here is MIN_VERSION_Cabal is defined and available to custom Setup.hs scripts if either GHC >= 8.0 or cabal-install >= 1.24 is used. So if it isn't defined, it's very likely we don't have Cabal >= 2.0.
Copy link
Collaborator

@vshabanov vshabanov Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Am I right that "Custom-setup" stanza is only supported in cabal-install >= 1.24 ?
Copy link
Contributor Author

@glguy glguy Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. Older versions of Cabal don't know what that section is and will issue a warning and ignore it.
#define MIN_VERSION_Cabal(x,y,z) 0
#endif

import Distribution.Simple
import Distribution.Simple.Setup (ConfigFlags(..), toFlag)
import Distribution.Simple.LocalBuildInfo (localPkgDescr)

#if __GLASGOW_HASKELL__ >= 802
#if MIN_VERSION_Cabal(2,0,0)
import Distribution.PackageDescription (FlagName(..), mkFlagName)
#else
import Distribution.PackageDescription (FlagName(..))
Expand All @@ -18,6 +22,10 @@ import System.IO.Error (isUserError)
import Control.Monad (forM)
import Data.List

#if !(MIN_VERSION_Cabal(2,0,0))
mkFlagName = FlagName
#endif

-- On macOS we're checking whether OpenSSL library is avaiable
-- and if not, we're trying to find Homebrew or MacPorts OpenSSL installations.
--
Expand Down Expand Up @@ -97,8 +105,3 @@ tryConfig descr flags = do

where ue e | isUserError e = Just e
| otherwise = Nothing

#if __GLASGOW_HASKELL__ < 802
mkFlagName = FlagName
#endif