Update custom setup script for Cabal-2.0 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hvr reviewed Apr 26, 2017
| {-# LANGUAGE CPP #-} | ||
| {-# LANGUAGE TupleSections #-} | ||
| | ||
| #ifndef MIN_VERSION_Cabal |
There was a problem hiding this comment.
just in case this doesn't seem obvious: the trick here is MIN_VERSION_Cabal is defined and available to custom Setup.hs scripts if either GHC >= 8.0 or cabal-install >= 1.24 is used. So if it isn't defined, it's very likely we don't have Cabal >= 2.0.
There was a problem hiding this comment.
Thank you. Am I right that "Custom-setup" stanza is only supported in cabal-install >= 1.24 ?
There was a problem hiding this comment.
That's right. Older versions of Cabal don't know what that section is and will issue a warning and ignore it.
| It's nice that older cabal-install will still work. Merged and uploaded on Hackage (HsOpenSSL-0.11.4.8) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Development versions of cabal-install or Cabal (I'm not sure which) will assume that if you don't provide a custom-setup section in your Cabal file that you don't support new versions of Cabal.
@hvr has updated the cabal-file metadata for HsOpenSSL to work with development versions of Cabal already. Putting this change into the repository will ensure that those changes survive for the next release.
Additionally I've update the Setup.hs to decide which code to use based on the Cabal version and not the GHC version. With new-build in particular GHC and Cabal versions are not related.