Skip to content

Add BitTiming/BitTimingFd support to KvaserBus #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2023
Merged

Add BitTiming/BitTimingFd support to KvaserBus #1510

merged 4 commits into from
Oct 16, 2023

Conversation

zariiii9003
Copy link
Collaborator

Can someone with a Kvaser device test KvaserBus instantiation with BitTiming and BitTimingFd?
@zariiii9003 zariiii9003 added this to the Next Release milestone Jan 27, 2023
@zariiii9003 zariiii9003 mentioned this pull request May 11, 2023
Open
@zariiii9003 zariiii9003 marked this pull request as ready for review October 14, 2023 22:56
@zariiii9003 zariiii9003 requested a review from lumagi October 14, 2023 22:56
@zariiii9003
Copy link
Collaborator Author

@lumagi I'd like to include this one in 4.3. We'll start with a release candidate anyway. Could you take a look?
lumagi
lumagi reviewed Oct 16, 2023
View reviewed changes
lumagi
lumagi approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@lumagi lumagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very fine to me. I think the legacy code paths should be executed just fine in case no timing parameter is passed.
@zariiii9003 zariiii9003 merged commit 2d60900 into hardbyte:develop Oct 16, 2023
@zariiii9003 zariiii9003 deleted the bittiming_kvaser branch January 21, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend:kvaser help wanted

2 participants

@zariiii9003 @lumagi