Allow restarting of transmission tasks for socketcan #1440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Merged
zariiii9003 reviewed Nov 17, 2022
Co-authored-by: zariiii9003 <52598363+zariiii9003@users.noreply.github.com>
hardbyte added a commit that referenced this pull request Nov 24, 2022
* Allow restarting of transmission tasks for socketcan * Update can/interfaces/socketcan/socketcan.py Co-authored-by: zariiii9003 <52598363+zariiii9003@users.noreply.github.com>
lumagi added a commit to lumagi/python-can that referenced this pull request Jan 14, 2023
Previously, it was not permitted to restart an already started period send task for SocketCAN. This behavior was changed in PR hardbyte#1440. This commit adjusts the test to reflect this change.
zariiii9003 pushed a commit that referenced this pull request Jan 14, 2023
* Update CI to set up vcan and run SocketCAN tests * Add test to document PyPy raw CAN socket implementation status * Update test for restarting of SocketCAN SendTask Previously, it was not permitted to restart an already started period send task for SocketCAN. This behavior was changed in PR #1440. This commit adjusts the test to reflect this change. * Update PyPy raw CAN socket test failure into warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was going through the examples and found that restarting BCM tasks was broken.
The error is due to a requirement that the transmission task NOT exist in kernel space when sending the restart message. I'm not sure how long it has been broken for.
@hartkopp would you mind checking my logic?