Release 4.1.0

[hardbyte]

No description provided.

[hardbyte]

Oh, travis previously published the wheels - I'll upload an a0 release manually but perhaps we should get github to build and publish the artifacts.

[hardbyte]

Scary how easy that is... https://pypi.org/project/python-can/4.1.0a0/

pip install python-can==4.1.0a0 

[hardbyte]

I've adjusted the coveralls settings to be a bit less picky:

[felixdivo]

Scary how easy that is

That's what I thought after my first upload (version 4.0.0) 😅 "Please don't upload something wrong ..."

But doing it in a fresh Docker container kinda helped to make sure to not be bothered with potentially misconfigured local setups.

[zariiii9003]

We could setup automatic releases whenever a git tag starting with "v*" is pushed. Like this
That tag pattern must be added to protected tags in the project settings.

[felixdivo]

We could setup automatic releases whenever a git tag starting with "v*" is pushed.

This could also be used to more regularly push out pre-releases.

[zariiii9003]

Updating mypy might be a bit difficult, i tried before 😄
Let's leave that for a separate PR.

[hardbyte]

Updating mypy might be a bit difficult, i tried before smile Let's leave that for a separate PR.

🤞🏼 it works for everything on the CI though...

[zariiii9003]

🤞🏼 it works for everything on the CI though...

I had trouble getting it to pass on both Windows and Linux because of "warn_unused_ignores = True". It was always either Windows OR Linux, not both

[hardbyte]

I had trouble getting it to pass on both Windows and Linux because of "warn_unused_ignores = True". It was always either Windows OR Linux, not both

As we're only running the static analysis tests in linux I think that we're okay with mypi.

I am wondering why pylint is passing fine locally but not on the CI though. Do we have a circular import problem?

************* Module examples.virtual_can_demo examples/virtual_can_demo.py:1:0: R0401: Cyclic import (can -> can.notifier -> can.bus) (cyclic-import) examples/virtual_can_demo.py:1:0: R0401: Cyclic import (can -> can.interface -> can.util) (cyclic-import) examples/virtual_can_demo.py:1:0: R0401: Cyclic import (can -> can.util) (cyclic-import) examples/virtual_can_demo.py:1:0: R0401: Cyclic import (can -> can.notifier -> can.listener -> can.bus) (cyclic-import) examples/virtual_can_demo.py:1:0: R0401: Cyclic import (can -> can.interface -> can.bus) (cyclic-import) examples/virtual_can_demo.py:1:0: R0401: Cyclic import (can -> can.thread_safe_bus -> can.interface -> can.util) (cyclic-import) 

In any case, I'm going to call it for tonight. Feel free to push to this branch (even reverting the pylint update).

[hardbyte]

Ok I lied, I'm waiting to see that green tick...

[hardbyte]

Prerelease uploaded by Github action (after I created the release in github UI)

https://pypi.org/project/python-can/4.1.0a1/

[felixdivo]

Looks good! Thanks for preparing the release 🙂

[zariiii9003]

👍

[j-c-cook]

🚀

[pierreluctg]

👍

[hardbyte]

Found a bug while testing examples - appreciate a second pair of eyes - #1440

[zariiii9003]

@hardbyte Could you try to remove appveyor?

We migrated all Windows tests to github anyway.

[hardbyte]

I've just removed the app veyor hook

[felixdivo]

Good catch in #1440. Is it in the changelog yet?

[hardbyte]

Good catch in #1440. Is it in the changelog yet?

Thanks! Yes I've just pushed it.