- Notifications
You must be signed in to change notification settings - Fork 70
chore(2.59.x): release 2.59.3 #3982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(2.59.x): release 2.59.3 #3982
Conversation
Summary of ChangesHello @suztomo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the release of version 2.59.1 for the project. It updates numerous version references across configuration files, build scripts, and documentation from development ( Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated release for version 2.59.1. The changes primarily consist of version bumps in various configuration files, which is standard for a release. I've found one significant inconsistency in the versioning of the gax-httpjson artifact that should be addressed.
versions.txt Outdated
| api-common:2.50.1:2.50.1 | ||
| gax:2.67.1:2.67.1 | ||
| gax-grpc:2.67.1:2.67.1 | ||
| gax-httpjson:0.152.1:0.152.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a version inconsistency for gax-httpjson. This file specifies version 0.152.1, but other files like gax-java/gax-httpjson/pom.xml are being updated to version 2.67.1 (inherited from gax). This is likely due to a misconfiguration in release-please where pom.xml files are updated using gax's version ({x-version-update:gax:current}), but versions.txt has a separate versioning scheme for gax-httpjson.
To resolve this, gax-httpjson should be consistently versioned. Given that POMs are being updated to 2.67.1, this file should reflect that as well.
gax-httpjson:2.67.1:2.67.1 c2fe18c to 22ecf71 Compare 22ecf71 to 04d97d4 Compare The manifest value comes from the previous release being 2.59.0. The 2.59.2 was already made on the main branch: https://github.com/googleapis/sdk-platform-java/tree/v2.59.2
| 🤖 Created releases: 🌻 |
🤖 I have created a release beep boop
2.59.3 (2025-11-05)
Bug Fixes
This PR was generated with Release Please. See documentation.