- Notifications
You must be signed in to change notification settings - Fork 70
fix: (2.59.x) fix release-please-manifest and versions.txt #3983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In 2.59.x releases, we already have .2 release versions. For example, gax already has 2.67.2. https://central.sonatype.com/artifact/com.google.api/gax/2.67.2 The next release from this branch should be ".3" versions.
Summary of ChangesHello @suztomo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue with release versioning by synchronizing the project's internal version tracking files. It updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to update the versioning configuration to prepare for the next release cycle. The changes in .release-please-manifest.json and versions.txt correctly reflect the move to .3 snapshot versions, based on previous .2 releases. However, the pull request is incomplete as the corresponding version updates in the Maven pom.xml files are missing. This creates a critical inconsistency that will likely break the build and needs to be addressed.
| gapic-generator-java:2.59.2:2.59.3-SNAPSHOT | ||
| api-common:2.50.2:2.50.3-SNAPSHOT | ||
| gax:2.67.2:2.67.3-SNAPSHOT | ||
| gax-grpc:2.67.2:2.67.3-SNAPSHOT | ||
| gax-httpjson:0.152.2:0.152.3-SNAPSHOT | ||
| proto-google-common-protos:2.58.2:2.58.3-SNAPSHOT | ||
| grpc-google-common-protos:2.58.2:2.58.3-SNAPSHOT | ||
| proto-google-iam-v1:1.53.2:1.53.3-SNAPSHOT | ||
| grpc-google-iam-v1:1.53.2:1.53.3-SNAPSHOT | ||
| proto-google-iam-v2beta:1.53.2:1.53.3-SNAPSHOT | ||
| grpc-google-iam-v2beta:1.53.2:1.53.3-SNAPSHOT | ||
| google-iam-policy:1.53.2:1.53.3-SNAPSHOT | ||
| proto-google-iam-v2:1.53.2:1.53.3-SNAPSHOT | ||
| grpc-google-iam-v2:1.53.2:1.53.3-SNAPSHOT | ||
| google-cloud-core:2.57.2:2.57.3-SNAPSHOT | ||
| google-cloud-shared-dependencies:3.49.2:3.49.3-SNAPSHOT | ||
| gapic-showcase:0.5.2:0.5.3-SNAPSHOT | ||
| proto-gapic-showcase-v1beta1:0.5.2:0.5.3-SNAPSHOT | ||
| grpc-gapic-showcase-v1beta1:0.5.2:0.5.3-SNAPSHOT | ||
| proto-google-iam-v3:1.53.2:1.53.3-SNAPSHOT | ||
| grpc-google-iam-v3:1.53.2:1.53.3-SNAPSHOT | ||
| proto-google-iam-v3beta:1.53.2:1.53.3-SNAPSHOT | ||
| grpc-google-iam-v3beta:1.53.2:1.53.3-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The snapshot versions for all modules have been updated here, but the corresponding pom.xml files have not been changed. This will cause a mismatch between the versions defined here and the versions used in the build.
For example:
versions.txtsetsgapic-generator-java's current version to2.59.3-SNAPSHOT.- However,
gapic-generator-java/pom.xmlstill has<version>2.59.1-SNAPSHOT</version>.
This discrepancy applies to all modules listed in this file. For the showcase modules, the versions in their pom.xml files (e.g., 0.0.1-SNAPSHOT in java-showcase/gapic-showcase/pom.xml) are completely different from the versions in this file (0.5.3-SNAPSHOT).
Please update all relevant pom.xml files to use the new snapshot versions to ensure consistency.
🤖 I have created a release *beep* *boop* --- ## [2.59.3](v2.59.0...v2.59.1) (2025-11-05) ### Bug Fixes * (2.59.x) fix release-please-manifest and versions.txt ([#3983](#3983)) ([ca1156d](ca1156d)) * (branch 2.59.x)empty changes in README.md to trigger a test release ([#3980](#3980)) ([c940671](c940671)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
In 2.59.x releases, we already have .2 release versions. For example,
gax already has 2.67.2.
https://central.sonatype.com/artifact/com.google.api/gax/2.67.2
The next release from this branch should be ".3" versions.