Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented May 1, 2025

See b/392225607

@lqiu96 lqiu96 requested a review from suztomo May 1, 2025 15:38
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 1, 2025
</dependency>
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-utils</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A minor thing) Did you find this line is needed? I think dependencyManagement section is enough.

Copy link
Member Author

@lqiu96 lqiu96 May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, let me double check this. I think you're right that this may not be needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, removed. Thanks!

@lqiu96 lqiu96 enabled auto-merge (squash) May 1, 2025 18:11
@lqiu96 lqiu96 merged commit 7ec93c3 into main May 1, 2025
74 of 76 checks passed
@lqiu96 lqiu96 deleted the update-maven-shared-utils branch May 1, 2025 18:25
lqiu96 added a commit that referenced this pull request May 2, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>2.56.3</summary> ## [2.56.3](v2.56.2...v2.56.3) (2025-05-02) ### Bug Fixes * Only send mtlsEndpoint if it is non-null ([#3767](#3767)) ([8f8df7b](8f8df7b)) * subscribe Airlock Docker image definition to GRPC updates ([#3765](#3765)) ([d0f43e3](d0f43e3)) ### Dependencies * update dependency com.google.errorprone:error_prone_annotations to v2.38.0 ([#3773](#3773)) ([e16fe65](e16fe65)) * update gapic-showcase to 36.2 ([#3771](#3771)) ([15b2577](15b2577)) * update google auth library dependencies to v1.34.0 ([#3772](#3772)) ([406a180](406a180)) * Update maven-shared-utils to v3.2.1 ([#3768](#3768)) ([7ec93c3](7ec93c3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
lqiu96 added a commit that referenced this pull request Jun 10, 2025
lqiu96 added a commit that referenced this pull request Jun 10, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>2.56.3</summary> ## [2.56.3](v2.56.2...v2.56.3) (2025-05-02) ### Bug Fixes * Only send mtlsEndpoint if it is non-null ([#3767](#3767)) ([8f8df7b](8f8df7b)) * subscribe Airlock Docker image definition to GRPC updates ([#3765](#3765)) ([d0f43e3](d0f43e3)) ### Dependencies * update dependency com.google.errorprone:error_prone_annotations to v2.38.0 ([#3773](#3773)) ([e16fe65](e16fe65)) * update gapic-showcase to 36.2 ([#3771](#3771)) ([15b2577](15b2577)) * update google auth library dependencies to v1.34.0 ([#3772](#3772)) ([406a180](406a180)) * Update maven-shared-utils to v3.2.1 ([#3768](#3768)) ([7ec93c3](7ec93c3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
lqiu96 added a commit that referenced this pull request Aug 21, 2025
lqiu96 added a commit that referenced this pull request Aug 21, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>2.56.3</summary> ## [2.56.3](v2.56.2...v2.56.3) (2025-05-02) ### Bug Fixes * Only send mtlsEndpoint if it is non-null ([#3767](#3767)) ([8f8df7b](8f8df7b)) * subscribe Airlock Docker image definition to GRPC updates ([#3765](#3765)) ([d0f43e3](d0f43e3)) ### Dependencies * update dependency com.google.errorprone:error_prone_annotations to v2.38.0 ([#3773](#3773)) ([e16fe65](e16fe65)) * update gapic-showcase to 36.2 ([#3771](#3771)) ([15b2577](15b2577)) * update google auth library dependencies to v1.34.0 ([#3772](#3772)) ([406a180](406a180)) * Update maven-shared-utils to v3.2.1 ([#3768](#3768)) ([7ec93c3](7ec93c3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
lqiu96 added a commit that referenced this pull request Aug 27, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>2.56.3</summary> ## [2.56.3](v2.56.2...v2.56.3) (2025-05-02) ### Bug Fixes * Only send mtlsEndpoint if it is non-null ([#3767](#3767)) ([8f8df7b](8f8df7b)) * subscribe Airlock Docker image definition to GRPC updates ([#3765](#3765)) ([d0f43e3](d0f43e3)) ### Dependencies * update dependency com.google.errorprone:error_prone_annotations to v2.38.0 ([#3773](#3773)) ([e16fe65](e16fe65)) * update gapic-showcase to 36.2 ([#3771](#3771)) ([15b2577](15b2577)) * update google auth library dependencies to v1.34.0 ([#3772](#3772)) ([406a180](406a180)) * Update maven-shared-utils to v3.2.1 ([#3768](#3768)) ([7ec93c3](7ec93c3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

2 participants