fix: make HTTPDatastoreAPI compatible w/ microgen Gapic API #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ly pattern Toward #124
product-auto-label bot added the api: datastore 
google-cla bot added the cla: yes 
crwilcox approved these changes Dec 9, 2020
tseaver added a commit that referenced this pull request Dec 14, 2020
This was referenced Dec 14, 2020
1 task
crwilcox pushed a commit that referenced this pull request Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
HTTPDatastoreAPIto userequestargument, rather than unpacked args.retryandtimeoutsupport to all API-invoking methods ofHTTPDatastoreAPI.HTTPDatastoreAPI(running withGOOGLE_DISABLE_RPCenvvar set).Closes #124.
Closes #132.
Closes #133.
Closes #134.