fix: request paramter error when grpc disable #132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
product-auto-label bot added the api: datastore 
tseaver suggested changes Dec 9, 2020
Comment on lines -184 to +190
| self, project_id, partition_id, read_options=None, query=None, gql_query=None | ||
| self, | ||
| project_id=None, | ||
| partition_id=None, | ||
| read_options=None, | ||
| query=None, | ||
| gql_query=None, | ||
| request=None, |
There was a problem hiding this comment.
This class is not part of the public API for the library, and its only caller is google.cloud.datastore.query.Iterator._next_page, which passes only request as a dict, and optionally retry / timeout. So, we should simplify:
def run_query(self, request, retry=None, timeout=None):| self.assertEqual(request.partition_id, partition_id._pb) | ||
| self.assertEqual(request.query, query_pb._pb) | ||
| | ||
| def test_run_query_w_request_as_dict(self): |
There was a problem hiding this comment.
Please factor out repeated setup code into helper methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #124