Skip to content

Conversation

@guyzmo
Copy link
Contributor

@guyzmo guyzmo commented May 4, 2017

repo.go Outdated
Private bool `json:"private"`
Fork bool `json:"fork"`
Empty bool `json:"empty"`
Size bool `json:"size"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size is not a boolean :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed as you were writing that 😁

@guyzmo guyzmo force-pushed the feature/api_exposes_extra_properties branch from a38eca4 to 66b7d30 Compare May 4, 2017 12:48
guyzmo added a commit to guyzmo/git-repo that referenced this pull request May 4, 2017
guyzmo added a commit to guyzmo/git-repo that referenced this pull request May 4, 2017
guyzmo added a commit to guyzmo/git-repo that referenced this pull request May 4, 2017
@guyzmo
Copy link
Contributor Author

guyzmo commented May 5, 2017

is there still an issue?

guyzmo added a commit to guyzmo/gogs that referenced this pull request May 5, 2017
Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
guyzmo added a commit to guyzmo/gogs that referenced this pull request May 5, 2017
Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
@guyzmo guyzmo force-pushed the feature/api_exposes_extra_properties branch from 932264d to 150f22a Compare May 5, 2017 21:26
* Add new field "Empty" to Repository structure * Fix Empty type to bool * Add Size property to Repository structure Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
@guyzmo guyzmo force-pushed the feature/api_exposes_extra_properties branch from 150f22a to dcc0d6c Compare May 5, 2017 21:36
guyzmo added a commit to guyzmo/gogs that referenced this pull request May 10, 2017
Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
@guyzmo guyzmo force-pushed the feature/api_exposes_extra_properties branch from dcc0d6c to 6fb98c4 Compare May 11, 2017 11:35
Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
@guyzmo guyzmo force-pushed the feature/api_exposes_extra_properties branch from 6fb98c4 to 9769715 Compare May 11, 2017 11:35
@guyzmo
Copy link
Contributor Author

guyzmo commented May 30, 2017

is it ok?

FYI, I've had that same change accepted and merged into gitea, I did my best to make sure any changes they required from me has been mirrored in that branch, but I can have done some mistakes!

@unknwon
Copy link
Member

unknwon commented May 30, 2017

Yeah, I didn't notice the correlated PR in the Gogs mai repository. Should be able review and merge tonight.

@guyzmo
Copy link
Contributor Author

guyzmo commented May 30, 2017

brilliant 👍

@unknwon
Copy link
Member

unknwon commented May 31, 2017

Thank you!

@unknwon unknwon merged commit 04c2783 into gogs:master May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants