Adds Parent property to the repo API

[guyzmo]

hop! 👍

cf gogs/go-gogs-client#64

[lafriks]

@guyzmo you need to create PR to https://github.com/go-gitea/go-sdk to add required field

[guyzmo]

done

[guyzmo]

I just changed the content, to expose Repository* BaseRepo as 'parent' property, instead of an id. because that's more restful.

[guyzmo]

cf github API, the parent is a full object. The only difference is that the parent does not contain its own parent in the project's tree (to avoid blowing up the connection). Also there's a source attribute, that contain the upmost parent project of the tree.

I guess that we can start iteratively, and give the parent property as it is currently implemented, at the risk of blowing the connection in case the project tree's branch is huge. Then in a second stage, hack the parent property so that it does not contain itself another parent property, or at least is set to null (and thus fork=true + parent=null means that there's more).

[lafriks]

This code will panic when BaseRepo is nil. Also I'm not quite sure if BaseRepo will be have value at all before GetBaseRepo is called

[guyzmo]

👌, so we need the code to keep calm when BaseRepo is nil. How?
And also we need to make sure that BaseRepo is valued when the API needs it. How?

I don't know the code base enough to tell how to hack that, so any pointers are welcomed ☺

[lunny]

@guyzmo first at all, you should use govendor update code.gitea.io/sdk to update the dependency.

[lafriks]

Now that dependency is set correctly you can see that unit tests is failing where BaseRepo is nil

[guyzmo]

So what can be done, how can we make sure it's 👌 when the pointer is nil and also that a tentative is made to resolve the parent when not?

[lafriks]

you need to move out assignment up something like:

var parent *api.Repository if repo.BaseRepo != nil { parent = repo.BaseRepo.APIFormat(AccessModeNone) }

[guyzmo]

and to make sure the repo.BaseRepo contains something?

[lafriks]

Then just assign Parent: parent,

[lafriks]

If you meant to actually load BaseRepo than it should be done outside APIFormat in function from where APIFormat is called

[guyzmo]

ok, I've tried something to force load the BaseRepo. The build is failing, but it doesn't look like related to that code I wrote, but I might be wrong.

[lafriks]

it must be parent = repo.BaseRepo...

[guyzmo]

and I guess parent := nil as well. My bad! 👍

[lafriks]

if isParent is true no need to try to call GetBaseRepo as it's result will not be used anyway

[bkcsoft]

True :)

[guyzmo]

👌

[bkcsoft]

just "APIFormat: %v", err ;)

[guyzmo]

👌

[bkcsoft]

now it's LGTM 🎉

[lafriks]

LGTM

[lunny]

blank line

[guyzmo]

done 👌

[lunny]

let L-G-T-M work