Fix extension soft lock when inspecting Dictionary variables with Variant key types #854
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello,
In some cases the extension would soft lock making it impossible to inspect variables. The symptoms are very similar to #699, except this time the problem is caused by typed dictionaries that have
Variantas a value type.To reproduce try setting a breakpoint in the script below and inspecting contents of
my_dict.The issue replicates on Godot 4.4 (and possibly newer versions) on both Windows and MacOs.
The solution is to container check type flags and then decode type info only if flag is nonzero. If flag === 0 then there will be no type information included in the buffer.