Skip to content

fix: don't suggest internal tasks #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix: don't suggest internal tasks #2323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,6 +957,15 @@ func TestFuzzyModel(t *testing.T) {
),
WithTask("install"),
)

NewExecutorTest(t,
WithName("intern"),
WithExecutorOptions(
task.WithDir("testdata/fuzzy"),
),
WithTask("intern"),
WithRunError(),
)
}

func TestIncludeChecksum(t *testing.T) {
Expand Down
3 changes: 3 additions & 0 deletions setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ func (e *Executor) setupFuzzyModel() {

var words []string
for name, task := range e.Taskfile.Tasks.All(nil) {
if task.Internal {
continue
}
words = append(words, name)
words = slices.Concat(words, task.Aliases)
}
Expand Down
5 changes: 5 additions & 0 deletions testdata/fuzzy/Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@ version: 3

tasks:
install: echo 'install'

internal:
internal: true
cmds:
- echo "internal"
1 change: 1 addition & 0 deletions testdata/fuzzy/testdata/TestFuzzyModel-intern-err-run.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
task: Task "intern" does not exist
1 change: 1 addition & 0 deletions testdata/fuzzy/testdata/TestFuzzyModel-intern.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
task: No tasks with description available. Try --list-all to list all tasks
Loading