fix: don't suggest internal tasks #2323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pd93 reviewed Jul 9, 2025
maxmzkrcensys force-pushed the maxmzkr/dont-suggest-internal branch from 7e600f8 to a50756c Compare 
maxmzkrcensys force-pushed the maxmzkr/dont-suggest-internal branch from a50756c to a37a407 Compare pd93 approved these changes Jul 9, 2025
andreynering approved these changes Jul 9, 2025
pd93 added a commit that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #2309
Internal tasks cannot be ran from the command line, so it doesn't make sense to suggest them when fixing typos on the command line
Without the changes, the added test fails with