Skip to content

位点信息增加canal时间戳支持，可向用户端展示消费延迟时间 #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

位点信息增加canal时间戳支持，可向用户端展示消费延迟时间 #739

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79949b0
位点信息增加canal时间戳支持，可向用户端展示消费延迟时间
BLAZZ Nov 25, 2022
abb6ab2
support for local binlog file like aliyun rds
BLAZZ Nov 25, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions canal/sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ func (c *Canal) runSyncBinlog() error {

// next binlog pos
pos.Pos = ev.Header.LogPos
pos.Timestamp = ev.Header.Timestamp

// new file name received in the fake rotate event
if fakeRotateLogName != "" {
Expand Down
2 changes: 2 additions & 0 deletions mysql/position.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import (
type Position struct {
Copy link
Collaborator

@lance6716 lance6716 Nov 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this structure represents the binlog position which can starts a position-based replication, so we should not add other fields. Maybe you can add a new interface EventHandlerV2 with OnXID(nextPos mysql.Position, xidEvent *replication.XIDEvent) error.

And please translate the PR description to English so I can refer non-Chinese reviewers.
Name string
Pos uint32

Timestamp uint32 // for canal handler to show delay time
}

func (p Position) Compare(o Position) int {
Expand Down