Skip to content

位点信息增加canal时间戳支持，可向用户端展示消费延迟时间 #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

位点信息增加canal时间戳支持，可向用户端展示消费延迟时间 #739

wants to merge 2 commits into from

Conversation

@BLAZZ
Copy link
Contributor

@BLAZZ BLAZZ commented Nov 25, 2022

handler可以获取位点时间戳，用于展示延迟信息：

func (h *handler) OnXID(nextPos mysql.Position) error { h.queue <- model.Position{ Name: nextPos.Name, Pos: nextPos.Pos, Timestamp: nextPos.Timestamp, Force: false,	} return nil }

展示：
binlog文件：mysql-bin.000102
binlog位点：1142900
binlog时间戳：2022-11-25 15:54:07 (1669362847)
距离上次更新： 2秒
lance6716
lance6716 reviewed Nov 25, 2022
View reviewed changes
mysql/position.go
)

// For binlog filename + position based replication
type Position struct {
Copy link
Collaborator

@lance6716 lance6716 Nov 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this structure represents the binlog position which can starts a position-based replication, so we should not add other fields. Maybe you can add a new interface EventHandlerV2 with OnXID(nextPos mysql.Position, xidEvent *replication.XIDEvent) error.

And please translate the PR description to English so I can refer non-Chinese reviewers.
@BLAZZ BLAZZ closed this by deleting the head repository Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@BLAZZ @lance6716