Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 12, 2023

Per #22845 (comment)

Reverts #22845

Let's have a better PR.

@silverwind @zeripath

@lunny lunny added the issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change label Feb 12, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 12, 2023
@zeripath
Copy link
Contributor

Agh!!

I didn't properly read that PR all I saw was that the damned icons were all broken.

Deeply sorry.

@zeripath zeripath merged commit 00f695d into main Feb 12, 2023
@lunny lunny deleted the revert-22845-notif2 branch February 12, 2023 08:20
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 13, 2023
* upstream/main: Add some headings to repo views (go-gitea#22869) Fix style of actions rerun button (go-gitea#22835) Make issue and code search support camel case (go-gitea#22829) Revert "Fix notification and stopwatch empty states" (go-gitea#22876) Deduplicate findReadmeFile() (go-gitea#22177) Fix milestone title font problem (go-gitea#22863) Fix PR file tree folders no longer collapsing (go-gitea#22864) escape filename when assemble URL (go-gitea#22850) Fix notification and stopwatch empty states (go-gitea#22845) Fix .golangci.yml (go-gitea#22868) Fix migration issue. (go-gitea#22867) Add `/$count` endpoints for NuGet v2 (go-gitea#22855) Preview images for Issue cards in Project Board view (go-gitea#22112) Fix improper HTMLURL usages in Go code (go-gitea#22839) Use proxy for pull mirror (go-gitea#22771)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

4 participants