Fix improper HTMLURL usages in Go code #22839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
techknowlogick pushed a commit that referenced this pull request Feb 9, 2023
After some PRs: * #21986 * #22795 * #22808 * #22831 * #22839 Users won't be affected by the ROOT_URL problem in most cases. Close #19345 This PR improves AppUrl/ROOT_URL checking, only check it on the admin page, and the message is also updated. Feel free to suggest about more English-native messages. 
techknowlogick added type/bug skip-changelog 
KN4CK3R approved these changes Feb 9, 2023
GiteaBot added the lgtm/need 1 
wolfogre approved these changes Feb 10, 2023
GiteaBot added lgtm/done 
lunny added the reviewed/wait-merge 
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@ ## main #22839 +/- ## ======================================= Coverage 47.30% 47.31% ======================================= Files 1113 1113 Lines 150077 150077 ======================================= + Hits 70987 71002 +15 + Misses 70657 70646 -11 + Partials 8433 8429 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| LG-TM bot |
lunny removed the reviewed/wait-merge zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 13, 2023
* upstream/main: Add some headings to repo views (go-gitea#22869) Fix style of actions rerun button (go-gitea#22835) Make issue and code search support camel case (go-gitea#22829) Revert "Fix notification and stopwatch empty states" (go-gitea#22876) Deduplicate findReadmeFile() (go-gitea#22177) Fix milestone title font problem (go-gitea#22863) Fix PR file tree folders no longer collapsing (go-gitea#22864) escape filename when assemble URL (go-gitea#22850) Fix notification and stopwatch empty states (go-gitea#22845) Fix .golangci.yml (go-gitea#22868) Fix migration issue. (go-gitea#22867) Add `/$count` endpoints for NuGet v2 (go-gitea#22855) Preview images for Issue cards in Project Board view (go-gitea#22112) Fix improper HTMLURL usages in Go code (go-gitea#22839) Use proxy for pull mirror (go-gitea#22771)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In Go code, HTMLURL should be only used for external systems, like API/webhook/mail/notification, etc.
If a URL is used by
Redirector rendered in a template, it should be a relative URL (akaLink()in Gitea)