Skip to content

Prevent "empty" scrollbars on Firefox #20294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2022
Merged

Prevent "empty" scrollbars on Firefox #20294

merged 3 commits into from
Jul 10, 2022

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jul 8, 2022 •
edited by zeripath
Loading

Addition to #20142

Fixes the "empty" scrollbars with Firefox by changing the scroll bar to auto.

Examples:
Git Graph
grafik

Admin Actions
grafik
@KN4CK3R KN4CK3R added this to the 1.18.0 milestone Jul 8, 2022
@KN4CK3R KN4CK3R requested a review from Gusted July 8, 2022 09:19
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 8, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 8, 2022
Gusted
Gusted approved these changes Jul 9, 2022
View reviewed changes
Copy link
Contributor

@Gusted Gusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works as intended.
@codecov-commenter
Copy link

Codecov Report

Merging #20294 (536ce37) into main (9f3906b) will increase coverage by 0.19%.
The diff coverage is n/a.

@@ Coverage Diff @@ ## main #20294 +/- ## ========================================== + Coverage 46.73% 46.93% +0.19%  ========================================== Files 976 976 Lines 135007 135007 ========================================== + Hits 63101 63367 +266  + Misses 64208 63882 -326  - Partials 7698 7758 +60
Impacted Files Coverage Δ
modules/process/manager_exec.go 86.04% <0.00%> (-6.98%) ⬇️
models/unit/unit.go 47.00% <0.00%> (-1.71%) ⬇️
services/pull/pull.go 40.18% <0.00%> (-0.16%) ⬇️
modules/log/event.go 60.27% <0.00%> (+2.09%) ⬆️
models/asymkey/gpg_key_common.go 56.57% <0.00%> (+3.94%) ⬆️
modules/queue/queue_bytefifo.go 51.62% <0.00%> (+4.33%) ⬆️
routers/web/repo/setting.go 16.92% <0.00%> (+6.11%) ⬆️
routers/web/repo/wiki.go 37.56% <0.00%> (+33.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f3906b...536ce37. Read the comment docs.
@wxiaoguang wxiaoguang merged commit e24b0fc into go-gitea:main Jul 10, 2022
@KN4CK3R KN4CK3R deleted the fix-scroll branch July 10, 2022 17:34
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Jul 10, 2022
@KN4CK3R
Changed scroll to auto for some UI elements. (go-gitea#20294)
f97d30a 
Addition to: Show scrollbar when necessary go-gitea#20142 Fixes the "empty" scrollbars with Firefox.
@KN4CK3R KN4CK3R mentioned this pull request Jul 10, 2022
Merged
@zeripath zeripath changed the title Changed scroll to auto. Prevent the "empty" scrollbars with Firefox. Jul 10, 2022
@zeripath zeripath changed the title Prevent the "empty" scrollbars with Firefox. Prevent "empty" scrollbars with Firefox. Jul 10, 2022
@zeripath zeripath changed the title Prevent "empty" scrollbars with Firefox. Prevent "empty" scrollbars with Firefox Jul 10, 2022
zeripath pushed a commit that referenced this pull request Jul 10, 2022
@KN4CK3R
Prevent "empty" scrollbars on Firefox (#20294) (#20308)
c556a83 
Addition to: Show scrollbar when necessary #20142 Fixes the "empty" scrollbars with Firefox.
@zeripath zeripath changed the title Prevent "empty" scrollbars with Firefox Prevent "empty" scrollbars on Firefox Jul 10, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 11, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b2d7cf0 
* giteaofficial/main: [skip ci] Updated translations via Crowdin Vertical align avatar at middle (go-gitea#20302) Changed scroll to auto for some UI elements. (go-gitea#20294) Add hint to GNUPGHOME environment variable (go-gitea#20134) Refactor SSH init code, fix directory creation for TrustedUserCAKeys file (go-gitea#20299) [skip ci] Updated translations via Crowdin Use dedicated draft PR icon when possible (go-gitea#20303) Update goldmark (go-gitea#20300) Do not create empty ".ssh" directory when loading config (go-gitea#20289)
@6543 6543 added the backport/done All backports for this PR have been created label Jul 12, 2022
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@KN4CK3R
Changed scroll to auto for some UI elements. (go-gitea#20294)
caaf48d 
Addition to: Show scrollbar when necessary go-gitea#20142 Fixes the "empty" scrollbars with Firefox.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

8 participants

@KN4CK3R @codecov-commenter @wxiaoguang @Gusted @delvh @GiteaBot @6543 @lunny