Show scrollbar when necessary #20142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Firefox on Windows will unconditionally show scrollbars when you specify `overflow: scroll`. This is bad behavior, as you don't always need the scrollbar. Changing the scroll value to auto fixes this issue and only shows the scrollbar when necessary. - Resolves go-gitea#20139
Gusted added type/bug skip-changelog Gusted pushed a commit to Gusted/gitea that referenced this pull request Jun 26, 2022
- Backport go-gitea#20142 - Firefox on Windows will unconditionally show scrollbars when you specify `overflow: scroll`. This is bad behavior, as you don't always need the scrollbar. Changing the scroll value to auto fixes this issue and only shows the scrollbar when necessary. - Resolves go-gitea#20139
KN4CK3R approved these changes Jun 26, 2022
GiteaBot added the lgtm/need 1 
delvh approved these changes Jun 26, 2022
GiteaBot added lgtm/done 
| LGTM |
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 28, 2022
* upstream/main: [skip ci] Updated translations via Crowdin Add username check to doctor (go-gitea#20140) Refactor `i18n` to `locale` (go-gitea#20153) Remove support for sr-SP (go-gitea#20155) Hide notify mail setting ui if not enabled (go-gitea#20138) Fix custom folder name in customization docs (go-gitea#20148) Add missing parameter for error in log message (go-gitea#20144) Show scrollbar when necessary (go-gitea#20142) # Conflicts: # templates/repo/issue/view_content/context_menu.tmpl
wxiaoguang pushed a commit that referenced this pull request Jul 10, 2022
Addition to: Show scrollbar when necessary #20142 Fixes the "empty" scrollbars with Firefox.
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Jul 10, 2022
Addition to: Show scrollbar when necessary go-gitea#20142 Fixes the "empty" scrollbars with Firefox.
zeripath pushed a commit that referenced this pull request Jul 10, 2022
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
- Firefox on Windows will unconditionally show scrollbars when you specify `overflow: scroll`. This is bad behavior, as you don't always need the scrollbar. Changing the scroll value to auto fixes this issue and only shows the scrollbar when necessary. - Resolves go-gitea#20139 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
Addition to: Show scrollbar when necessary go-gitea#20142 Fixes the "empty" scrollbars with Firefox.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
overflow: scroll. This is bad behavior, as you don't always need the scrollbar. Changing the scroll value to auto fixes this issue and only shows the scrollbar when necessary.