Skip to content

fix(core): Ensure logs past MAX_LOG_BUFFER_SIZE are not swallowed #18207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreiborza merged 3 commits into from
Nov 17, 2025
Merged

fix(core): Ensure logs past MAX_LOG_BUFFER_SIZE are not swallowed #18207

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
051356e
fix(core): Ensure logs past are not swallowed
andreiborza Nov 14, 2025
5697b7d
Add test
andreiborza Nov 14, 2025
f7a4d8b
Ensure log that triggers flush on MAX_LOG_BUFFER_SIZE is not swallowed
andreiborza Nov 14, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Ensure log that triggers flush on MAX_LOG_BUFFER_SIZE is not swallowed
  • Loading branch information
@andreiborza
andreiborza committed Nov 14, 2025
commit f7a4d8bf41f7116bd9ab8cf7edfd87b35345456a
6 changes: 4 additions & 2 deletions packages/core/src/logs/internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,16 @@ function setLogAttribute(
*/
export function _INTERNAL_captureSerializedLog(client: Client, serializedLog: SerializedLog): void {
const bufferMap = _getBufferMap();

const logBuffer = _INTERNAL_getLogBuffer(client);

if (logBuffer === undefined) {
bufferMap.set(client, [serializedLog]);
} else {
bufferMap.set(client, [...logBuffer, serializedLog]);
if (logBuffer.length >= MAX_LOG_BUFFER_SIZE) {
_INTERNAL_flushLogsBuffer(client, logBuffer);
bufferMap.set(client, [serializedLog]);
} else {
bufferMap.set(client, [...logBuffer, serializedLog]);
}
}
}
Expand Down
Loading