Skip to content

Conversation

@andreiborza
Copy link
Member

@andreiborza andreiborza commented Nov 14, 2025

Looks like we swallowed the log that triggers a flush when MAX_LOG_BUFFER_SIZE is surpassed.

Test demonstrating issue: 5697b7d
Fix: f7a4d8b

Related metrics pr: #18212
v9 backport: #18213

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,867 - 11,316 -22%
GET With Sentry 1,431 16% 1,654 -13%
GET With Sentry (error only) 6,174 70% 7,684 -20%
POST Baseline 1,213 - 1,188 +2%
POST With Sentry 514 42% 573 -10%
POST With Sentry (error only) 1,069 88% 1,040 +3%
MYSQL Baseline 3,364 - 4,059 -17%
MYSQL With Sentry 502 15% 562 -11%
MYSQL With Sentry (error only) 2,751 82% 3,308 -17%

View base workflow run

@andreiborza andreiborza changed the title fix(core): Ensure logs past are not swallowed fix(core): Ensure logs past MAX_LOG_BUFFER_SIZE are not swallowed Nov 14, 2025
@andreiborza andreiborza merged commit e403d89 into develop Nov 17, 2025
380 of 383 checks passed
@andreiborza andreiborza deleted the ab/fix-logs-swallowing branch November 17, 2025 08:35
andreiborza added a commit that referenced this pull request Nov 17, 2025
…owed (#18212) Looks like we swallowed the metric that triggers a flush when MAX_METRIC_BUFFER_SIZE is surpassed. Test demonstrating issue: [f0737fa](f0737fa) Fix: [1a4e02a](1a4e02a) Related logs pr: #18207
andreiborza added a commit that referenced this pull request Nov 17, 2025
#18213) Looks like we swallowed the log that triggers a flush when `MAX_LOG_BUFFER_SIZE` is surpassed. Test demonstrating issue: [e3a8e2f](e3a8e2f) Fix: [ba24997](ba24997) v10 equivalent: #18207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants