Skip to content

Force ef in hf. #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2019
+9 −4
Merged

Force ef in hf. #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-scripts/scripts/utils/frontierInit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ function installFrontierDependencies(appPath, answers, ownPath) {
if (additionalFeatures.includes('polymer')) {
configurePolymer(appPath);
}
if (additionalFeatures.includes('electric-flow')) {
if (
additionalFeatures.includes('electric-flow') ||
additionalFeatures.includes('header-footer')
) {
configureEF(appPath, ownPath);
}
if (additionalFeatures.includes('header-footer')) {
Expand Down Expand Up @@ -143,6 +146,9 @@ function configureEF(appPath, ownPath) {
packageJson.scripts = sortScripts({ ...packageJson.scripts, ...additionalScripts });
return packageJson;
});

let modules = ['express'];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need express?
installModulesSync(modules, useYarn);
}

function configureHF(appPath, ownPath) {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/template-ef/Procfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
web: node src/server.js
web: node server.js
3 changes: 1 addition & 2 deletions ...s/react-scripts/template-ef/src/server.js → packages/react-scripts/template-ef/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
const path = require('path');
const express = require('express');
const app = express();

// Statically serve up the production built React App
app.use(express.static(`${__dirname}/build`));
app.use(express.static('build'));

const port = process.env.PORT || 3000;
app.listen(port, () => {
Expand Down