Skip to content

Force ef in hf. #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2019
Merged

Force ef in hf. #45

merged 1 commit into from
Feb 22, 2019

Conversation

@tylergraf
Copy link

Changes

  • force ef for hf
  • move server.js to root for ef
@joeycozza joeycozza merged commit 5e6b573 into develop Feb 22, 2019
@joeycozza joeycozza deleted the force-hf branch February 22, 2019 22:48
redbugz
redbugz reviewed Feb 23, 2019
View reviewed changes
packages/react-scripts/scripts/utils/frontierInit.js
return packageJson;
});

let modules = ['express'];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need express?
@joeycozza
Copy link

Quoting Tyler when I asked the same thing in slack.

The express is for ef without snow.

So people have the option to choose EF template without the Snow/HF template. So they "need" express explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@tylergraf @joeycozza @redbugz