upgraded usage of BinaryMessenger #4451

gaaclarke · 2021-10-25T17:29:18Z

flutter/engine#29147 introduced a breaking change to BinaryMessenger (breaking change guide coming). This upgrades all the files that had a dependency on that interface.

In order to accomplish this I added a new CI step that will modify code on the stable channel.

This PR also contains #4452 in order to fix the tree in one commit.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
I signed the CLA.
The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
I listed at least one issue that this PR fixes in the description above.
I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
I updated CHANGELOG.md to add a description of the change.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

ditman · 2021-10-26T00:38:04Z

In order to fix the web-platform_tests CHANNEL:master, I'm cherry-picking this PR here.

stuartmorgan-g

Please update the PR description to reflect that this is two unrelated PRs smashed together, and describe both of them.

.cirrus.yml

stuartmorgan-g · 2021-10-26T14:06:12Z

ci/stable_conditional.dart

+//
+// Example input:
+// int main() {
+// // FLUTTER_STABLE_CHANNEL_BEGIN


This naming is really confusing to me, since the name right after this is what is not going to be on the stable channel.

What if we reverse it and do:

// FLUTTER_STABLE_CHANNEL_BEGIN // [stable things] // FLUTTER_STABLE_CHANNEL_ELSE [not-stable things] // FLUTTER_STABLE_CHANNEL_END

Yea, that makes sense. With this naming "FLUTTER_STABLE_CHANNEL_" was just meant as a prefix for who is operating and not meant to be read as having meaning for the operation. Is there some way we can name it so that the master channel is on the top? I think it's easier to read the code if what is going to be happening the majority of the time is closer to the place where it will be. The exceptional code should be farther away.

// FLUTTER_STABLE_CONDITIONAL_IF_NOT_STABLE // FLUTTER_STABLE_CONDITIONAL_ELSE // FLUTTER_STABLE_CONDITIONAL_ENDIF

That way the prefix matches the name of the script, it keeps the naming similar to what you want but keeps the exceptional case at the bottom.

ci/stable_conditional.dart

...intent/android/src/test/java/io/flutter/plugins/androidintent/MethodCallHandlerImplTest.java

packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java

- renamed comments - forced `//` - put conditional in cirrus.yml - put explicit list of files to process - added space in comment

stuartmorgan-g

LGTM with nits

ci/stable_conditional.dart

gaaclarke · 2021-10-26T18:26:52Z

landing on red to open tree

This reverts commit 9d63517. The work to accomodate the breaking change is no longer necessary.

* master: Implement Android WebView api with pigeon (Java portion) (flutter#4441) [in_app_purchase] Update to the latest pkg:json_serializable (flutter#4434) Implement Android WebView api with pigeon (Dart portion) (flutter#4435) upgraded usage of BinaryMessenger (flutter#4451) [flutter_plugin_tools] Fix pubspec-check on Windows (flutter#4428) Use OpenJDK 11 in CI jobs (flutter#4419) [google_sign_in] remove the commented out code in tests (flutter#4442)

This reverts commit 9d63517. The work to accomodate the breaking change is no longer necessary.

* master: [ci.yaml] Main branch support (flutter#4440) [video_player] Initialize player when size and duration become available (flutter#4438) [webview_flutter] Implement zoom enabled for ios and android (flutter#4417) Partial revert of "upgraded usage of BinaryMessenger (flutter#4451)" (flutter#4453)

…ideo_src_on_same_controller * commit '76e84c0679dbab7bfaaaa553b17bb0dbdb9a3c33': (537 commits) [video_player] Initialize player when size and duration become available (flutter#4438) [webview_flutter] Implement zoom enabled for ios and android (flutter#4417) Partial revert of "upgraded usage of BinaryMessenger (flutter#4451)" (flutter#4453) Implement Android WebView api with pigeon (Java portion) (flutter#4441) [in_app_purchase] Update to the latest pkg:json_serializable (flutter#4434) Implement Android WebView api with pigeon (Dart portion) (flutter#4435) upgraded usage of BinaryMessenger (flutter#4451) [flutter_plugin_tools] Fix pubspec-check on Windows (flutter#4428) Use OpenJDK 11 in CI jobs (flutter#4419) [google_sign_in] remove the commented out code in tests (flutter#4442) [webview] Fix typos in the README (flutter#4249) [google_sign_in] add serverAuthCode to GoogleSignInAccount (flutter#4180) [ci] Update macOS Cirrus image to Xcode 13 (flutter#4429) [shared_preferences] Switch to new analysis options (flutter#4384) [flutter_plugin_android_lifecycle] remove placeholder dart file (flutter#4413) [camera] Run iOS methods on UI thread by default (flutter#4140) [ci] Always run all `format` steps (flutter#4427) [flutter_plugin_tools] Fix license-check on Windows (flutter#4425) [google_maps_flutter] Clean Java test, consolidate Marker example. (flutter#4400) [image_picker][android] suppress unchecked warning (flutter#4408) ... # Conflicts: # packages/video_player/video_player/pubspec.yaml # packages/video_player/video_player_web/lib/video_player_web.dart # packages/video_player/video_player_web/pubspec.yaml

Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>

…lutter#4453) This reverts commit 9d63517. The work to accomodate the breaking change is no longer necessary.

Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>

…lutter#4453) This reverts commit 9d63517. The work to accomodate the breaking change is no longer necessary.

google-cla bot added the cla: yes label Oct 25, 2021

github-actions bot added p: url_launcher platform-android labels Oct 25, 2021

gaaclarke force-pushed the upgrade-binary-messenger branch from 8c77df3 to 0e4c188 Compare October 25, 2021 17:35

github-actions bot added p: android_intent p: camera p: quick_actions labels Oct 25, 2021

gaaclarke force-pushed the upgrade-binary-messenger branch from 0e4c188 to bc16b95 Compare October 25, 2021 17:44

upgraded usage of BinaryMessenger

d0d9362

gaaclarke force-pushed the upgrade-binary-messenger branch 5 times, most recently from 26799c2 to 84d9fd4 Compare October 25, 2021 23:06

added script to massage stable channel tests

755e897

gaaclarke force-pushed the upgrade-binary-messenger branch from 84d9fd4 to 755e897 Compare October 25, 2021 23:11

[url_launcher_web] Regenerate mocks used by integration tests.

a5021dd

This comment has been minimized.

Sign in to view

google-cla bot added cla: no and removed cla: yes labels Oct 26, 2021

github-actions bot added the platform-web label Oct 26, 2021

This comment has been minimized.

Sign in to view

google-cla bot added cla: yes and removed cla: no labels Oct 26, 2021

ditman mentioned this pull request Oct 26, 2021

[url_launcher_web] Regenerate mocks used by integration tests. #4452

Closed

11 tasks

gaaclarke marked this pull request as ready for review October 26, 2021 00:56

gaaclarke requested a review from bparrishMines as a code owner October 26, 2021 00:56

gaaclarke requested a review from stuartmorgan-g October 26, 2021 00:56

stuartmorgan-g suggested changes Oct 26, 2021

View reviewed changes

stuart feedback:

8c69fa1

- renamed comments - forced `//` - put conditional in cirrus.yml - put explicit list of files to process - added space in comment

gaaclarke requested a review from stuartmorgan-g October 26, 2021 17:29

stuartmorgan-g approved these changes Oct 26, 2021

View reviewed changes

ci/stable_conditional.dart Outdated Show resolved Hide resolved

ci/stable_conditional.dart Outdated Show resolved Hide resolved

stuart feedback

34980e1

gaaclarke merged commit 9d63517 into flutter:master Oct 26, 2021

engine-flutter-autoroll mentioned this pull request Oct 26, 2021

Roll Plugins from 94b836eca365 to 9d63517bdcf9 (1 revision) flutter/flutter#92513

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 26, 2021

9d63517 upgraded usage of BinaryMessenger (flutter/plugins#4451)

8d9a37d

engine-flutter-autoroll mentioned this pull request Oct 26, 2021

Roll Plugins from 94b836eca365 to 97c2483be0d6 (2 revisions) flutter/flutter#92518

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 26, 2021

9d63517 upgraded usage of BinaryMessenger (flutter/plugins#4451)

d3d71d4

engine-flutter-autoroll mentioned this pull request Oct 27, 2021

Roll Plugins from 94b836eca365 to 97c2483be0d6 (2 revisions) flutter/flutter#92533

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 27, 2021

9d63517 upgraded usage of BinaryMessenger (flutter/plugins#4451)

5174663

engine-flutter-autoroll mentioned this pull request Oct 27, 2021

Roll Plugins from 94b836eca365 to 97c2483be0d6 (2 revisions) flutter/flutter#92543

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 27, 2021

9d63517 upgraded usage of BinaryMessenger (flutter/plugins#4451)

d521d8a

engine-flutter-autoroll mentioned this pull request Oct 27, 2021

Roll Plugins from 94b836eca365 to 0d330943941a (3 revisions) flutter/flutter#92546

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 27, 2021

9d63517 upgraded usage of BinaryMessenger (flutter/plugins#4451)

cc37f47

gaaclarke added a commit to gaaclarke/plugins that referenced this pull request Oct 27, 2021

Partial revert of "upgraded usage of BinaryMessenger (flutter#4451)"

47431f3

This reverts commit 9d63517. The work to accomodate the breaking change is no longer necessary.

gaaclarke added a commit to gaaclarke/plugins that referenced this pull request Oct 27, 2021

Partial revert of "upgraded usage of BinaryMessenger (flutter#4451)"

98974c2

This reverts commit 9d63517. The work to accomodate the breaking change is no longer necessary.

gaaclarke added a commit that referenced this pull request Oct 27, 2021

Partial revert of "upgraded usage of BinaryMessenger (#4451)" (#4453)

984015d

This reverts commit 9d63517. The work to accomodate the breaking change is no longer necessary.

amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021

upgraded usage of BinaryMessenger (flutter#4451)

306b2eb

Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>

amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021

Partial revert of "upgraded usage of BinaryMessenger (flutter#4451)" (f…

dd651a5

…lutter#4453) This reverts commit 9d63517. The work to accomodate the breaking change is no longer necessary.

KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021

upgraded usage of BinaryMessenger (flutter#4451)

ed7bafa

Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>

KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021

Partial revert of "upgraded usage of BinaryMessenger (flutter#4451)" (f…

f0ec302

…lutter#4453) This reverts commit 9d63517. The work to accomodate the breaking change is no longer necessary.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

upgraded usage of BinaryMessenger #4451

upgraded usage of BinaryMessenger #4451

Uh oh!

gaaclarke commented Oct 25, 2021 •

edited

Loading

ditman commented Oct 26, 2021

This comment has been minimized.

This comment has been minimized.

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Oct 26, 2021

gaaclarke Oct 26, 2021

gaaclarke Oct 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

gaaclarke commented Oct 26, 2021

Labels

3 participants

upgraded usage of BinaryMessenger #4451

upgraded usage of BinaryMessenger #4451

Uh oh!

Conversation

gaaclarke commented Oct 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

ditman commented Oct 26, 2021

This comment has been minimized.

This comment has been minimized.

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Oct 26, 2021

Choose a reason for hiding this comment

gaaclarke Oct 26, 2021

Choose a reason for hiding this comment

gaaclarke Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gaaclarke commented Oct 26, 2021

Labels

3 participants

gaaclarke commented Oct 25, 2021 •

edited

Loading