Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Oct 15, 2021

  • Remove unneeded class now that enum helpers can be generated without one
  • Code reorganization
  • Remove superflous JsonKey values
- Remove unneeded class now that enum helpers can be generated without one - Code reorganization - Remove superflous JsonKey values
@kevmoo
Copy link
Contributor Author

kevmoo commented Oct 20, 2021

Help here, @cyanglaz ?

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo kevmoo requested a review from cyanglaz October 21, 2021 17:26
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo
Copy link
Contributor Author

kevmoo commented Oct 21, 2021

@LHLL – do we need your approval, too?

@kevmoo kevmoo merged commit 0d33094 into master Oct 27, 2021
@kevmoo kevmoo deleted the json_serial_issue_778_try_out branch October 27, 2021 03:49
NickalasB added a commit to NickalasB/plugins that referenced this pull request Oct 27, 2021
* master: Implement Android WebView api with pigeon (Java portion) (flutter#4441) [in_app_purchase] Update to the latest pkg:json_serializable (flutter#4434) Implement Android WebView api with pigeon (Dart portion) (flutter#4435) upgraded usage of BinaryMessenger (flutter#4451) [flutter_plugin_tools] Fix pubspec-check on Windows (flutter#4428) Use OpenJDK 11 in CI jobs (flutter#4419) [google_sign_in] remove the commented out code in tests (flutter#4442)
NickalasB added a commit to NickalasB/plugins that referenced this pull request Oct 27, 2021
* master: Implement Android WebView api with pigeon (Java portion) (flutter#4441) [in_app_purchase] Update to the latest pkg:json_serializable (flutter#4434) Implement Android WebView api with pigeon (Dart portion) (flutter#4435) upgraded usage of BinaryMessenger (flutter#4451) [flutter_plugin_tools] Fix pubspec-check on Windows (flutter#4428) Use OpenJDK 11 in CI jobs (flutter#4419) [google_sign_in] remove the commented out code in tests (flutter#4442)
hofmannfelix pushed a commit to hofmannfelix/plugins that referenced this pull request Oct 30, 2021
…ideo_src_on_same_controller * commit '76e84c0679dbab7bfaaaa553b17bb0dbdb9a3c33': (537 commits) [video_player] Initialize player when size and duration become available (flutter#4438) [webview_flutter] Implement zoom enabled for ios and android (flutter#4417) Partial revert of "upgraded usage of BinaryMessenger (flutter#4451)" (flutter#4453) Implement Android WebView api with pigeon (Java portion) (flutter#4441) [in_app_purchase] Update to the latest pkg:json_serializable (flutter#4434) Implement Android WebView api with pigeon (Dart portion) (flutter#4435) upgraded usage of BinaryMessenger (flutter#4451) [flutter_plugin_tools] Fix pubspec-check on Windows (flutter#4428) Use OpenJDK 11 in CI jobs (flutter#4419) [google_sign_in] remove the commented out code in tests (flutter#4442) [webview] Fix typos in the README (flutter#4249) [google_sign_in] add serverAuthCode to GoogleSignInAccount (flutter#4180) [ci] Update macOS Cirrus image to Xcode 13 (flutter#4429) [shared_preferences] Switch to new analysis options (flutter#4384) [flutter_plugin_android_lifecycle] remove placeholder dart file (flutter#4413) [camera] Run iOS methods on UI thread by default (flutter#4140) [ci] Always run all `format` steps (flutter#4427) [flutter_plugin_tools] Fix license-check on Windows (flutter#4425) [google_maps_flutter] Clean Java test, consolidate Marker example. (flutter#4400) [image_picker][android] suppress unchecked warning (flutter#4408) ... # Conflicts: #	packages/video_player/video_player/pubspec.yaml #	packages/video_player/video_player_web/lib/video_player_web.dart #	packages/video_player/video_player_web/pubspec.yaml
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
…#4434) - Remove unneeded class now that enum helpers can be generated without one - Code reorganization - Remove superflous JsonKey values
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
…#4434) - Remove unneeded class now that enum helpers can be generated without one - Code reorganization - Remove superflous JsonKey values
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.