Skip to content

Conversation

martijn00
Copy link
Contributor

@martijn00 martijn00 commented May 23, 2024

Connection with issue(s)

Close #98
Close #97
Close #79
Close #80

Solution description

Tries to fix the problem with the build.

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme
@deandreamatias
Copy link
Contributor

Take a look on this docs about gitignore and pubignore
https://dart.dev/tools/pub/publishing#what-files-are-published

@deandreamatias
Copy link
Contributor

I think that need update the .gitignore with all stuff and **/intl and on .pubignore, all stuff but without the **/intl

@martijn00
Copy link
Contributor Author

@deandreamatias thanks that did the trick. Should the example app be included or ignored as well?

Otherwise this PR is good to go.

@deandreamatias
Copy link
Contributor

I would not add a validator in this PR, I would do it in another one as they are different things.

I think that the example can maintain the same setup that had

@martijn00
Copy link
Contributor Author

@deandreamatias Alright, fixed that. I'll open a new PR for it.

@martijn00 martijn00 mentioned this pull request May 24, 2024
5 tasks
@deandreamatias deandreamatias merged commit 18fa126 into flutter-form-builder-ecosystem:main May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants