Skip to content

Conversation

jhaglund
Copy link
Contributor

@jhaglund jhaglund commented May 22, 2024

Generated these with flutter gen-l10n

Connection with issue(s)

Close #97

Connected to #???

Solution description

Screenshots or Videos

The previous commit removed these files and took them out of version management. That might make sense long term, to have them generated more frequently, but they are not being auto-generated. So here they are.

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme
@martijn00
Copy link
Contributor

The question is why the files are not included when the CD build is being made. It is done here: https://github.com/flutter-form-builder-ecosystem/form_builder_validators/blob/main/.github/workflows/base.yaml#L89

This PR is not a proper fix and the CI should be fixed instead.

@deandreamatias
Copy link
Contributor

The question is why the files are not included when the CD build is being made. It is done here: https://github.com/flutter-form-builder-ecosystem/form_builder_validators/blob/main/.github/workflows/base.yaml#L89

This PR is not a proper fix and the CI should be fixed instead.

Because add to gitignore, automatically ignore by pub dev

@deandreamatias deandreamatias merged commit 9ef1aa0 into flutter-form-builder-ecosystem:main May 23, 2024
@martijn00
Copy link
Contributor

Yeah, but the question is why. Is there no option to include it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants