fix: FIR-49607 Make type casting invariant culture #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bogdantruta-firebolt force-pushed the FIR-49607-make-casting-use-invariant-culture branch 4 times, most recently from 7da47e2 to 729e78f Compare bogdantruta-firebolt force-pushed the FIR-49607-make-casting-use-invariant-culture branch from 729e78f to c876731 Compare 
|
goprean approved these changes Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As an improvement we are making all type casting culture invariant because Firebolt always returns decimals for example with a . as a decimal separator (cs-CZ culture uses " " as a thousands separator and "," as a decimal separator)