fix: FIR-49607 Make type casting invariant culture

Author: bogdantruta-firebolt

FireboltDotNetSdk.Tests/Unit/FireboltDataReaderTest.cs

@@ -2,6 +2,7 @@
 using System.Collections;
 using System.Data;
 using System.Text;
+using System.Globalization;
 using FireboltDotNetSdk.Utils;
 using FireboltDotNetSdk.Client;
 using FireboltDotNetSdk.Exception;
@@ -818,6 +819,62 @@ public void GetFieldValueGeneric_Struct_PocoDifferentShape_Throws()
  });
  }
 
+ [Test]
+ public void GetDouble_WithCzechCulture_CommaDecimalStringInDoubleColumn_Fails()
+ {
+ var originalCulture = CultureInfo.CurrentCulture;
+ try
+ {
+ CultureInfo.CurrentCulture = new CultureInfo("cs-CZ");
+ var result = new QueryResult
+ {
+ Rows = 1,
+ Meta = new List<Meta>() { new Meta() { Name = "val", Type = "double" } },
+ Data = new List<List<object?>>() { new List<object?>() { "2,71828" } }
+ };
+
+ DbDataReader reader = new FireboltDataReader(null, result);
+ Assert.Multiple(() =>
+ {
+ Assert.That(reader.Read(), Is.EqualTo(true));
+ //the conversion comes back as 271828 instead of 2.71828. This is because Firebolt always returns dot as decimal separator in JSON
+ Assert.That(Math.Abs(reader.GetDouble(0) - 2.71828), Is.Not.LessThanOrEqualTo(0.000001));
+ });
+ }
+ finally
+ {
+ CultureInfo.CurrentCulture = originalCulture;
+ }
+ }
+
+ [Test]
+ public void GetDouble_WithCzechCulture_DotDecimalStringInDoubleColumn_Succeeds()
+ {
+ var originalCulture = CultureInfo.CurrentCulture;
+ try
+ {
+ CultureInfo.CurrentCulture = new CultureInfo("cs-CZ");
+ var result = new QueryResult
+ {
+ Rows = 1,
+ Meta = new List<Meta>() { new Meta() { Name = "val", Type = "double" } },
+ Data = new List<List<object?>>() { new List<object?>() { "2.71828" } }
+ };
+
+ DbDataReader reader = new FireboltDataReader(null, result);
+ Assert.Multiple(() =>
+ {
+ Assert.That(reader.Read(), Is.EqualTo(true));
+ Assert.That(Math.Abs(reader.GetDouble(0) - 2.71828), Is.LessThanOrEqualTo(0.000001));
+ Assert.That(reader.GetString(0), Is.EqualTo("2,71828"));
+ });
+ }
+ finally
+ {
+ CultureInfo.CurrentCulture = originalCulture;
+ }
+ }
+
  class TestPoco
  {
  [FireboltStructName("int_val")] public int IntVal { get; init; }

FireboltNETSDK/Utils/Types.cs

@@ -73,16 +73,16 @@ public static class TypesConverter
  StructType structType => ToStruct(val, structType),
  _ => columnType.Type switch
  {
- FireboltDataType.Long => Convert.ToInt64(val),
- FireboltDataType.Int => Convert.ToInt32(val),
- FireboltDataType.Decimal => Convert.ToDecimal(val),
+ FireboltDataType.Long => Convert.ToInt64(val, CultureInfo.InvariantCulture),
+ FireboltDataType.Int => Convert.ToInt32(val, CultureInfo.InvariantCulture),
+ FireboltDataType.Decimal => Convert.ToDecimal(val, CultureInfo.InvariantCulture),
  FireboltDataType.String => val.ToString(),
  FireboltDataType.Geography => val.ToString(),
  FireboltDataType.DateTime => ParseDateTime(val),
  FireboltDataType.TimestampTz => ParseDateTime(val),
  FireboltDataType.TimestampNtz => ParseDateTime(val),
  FireboltDataType.Date => ParseDateTime(val),
- FireboltDataType.Short => Convert.ToInt16(val),
+ FireboltDataType.Short => Convert.ToInt16(val, CultureInfo.InvariantCulture),
  FireboltDataType.Double => ParseDouble(val),
  FireboltDataType.Float => ParseFloat(val),
  FireboltDataType.Boolean => ParseBoolean(val),
@@ -188,7 +188,7 @@ private static double ParseDouble(object val)
  {
  string str when DoubleInfinity.ContainsKey(str) => DoubleInfinity[str],
  double d => d,
- _ => Convert.ToDouble(val)
+ _ => Convert.ToDouble(val, CultureInfo.InvariantCulture)
  };
  }
 
@@ -198,7 +198,7 @@ private static float ParseFloat(object val)
  {
  string str when FloatInfinity.ContainsKey(str) => FloatInfinity[str],
  float f => f,
- _ => Convert.ToSingle(val)
+ _ => Convert.ToSingle(val, CultureInfo.InvariantCulture)
  };
  }