Skip to content

fix(analytics, web): use jsify with user properties #8852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022
Merged

fix(analytics, web): use jsify with user properties #8852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/firebase_analytics/firebase_analytics_web/lib/interop/analytics.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ class Analytics extends JsObjectWrapper<analytics_interop.AnalyticsJsImpl> {
AnalyticsCallOptions? callOptions,
}) {
return analytics_interop.logEvent(
jsObject, name, util.jsify(parameters ?? {}), callOptions);
jsObject,
name,
util.jsify(parameters ?? {}),
callOptions,
);
}

void setAnalyticsCollectionEnabled({required bool enabled}) {
Expand Down Expand Up @@ -77,7 +81,7 @@ class Analytics extends JsObjectWrapper<analytics_interop.AnalyticsJsImpl> {
}) {
return analytics_interop.setUserProperties(
jsObject,
{name: value},
util.jsify({name: value}),
callOptions,
);
}
Expand Down
6 changes: 4 additions & 2 deletions packages/firebase_analytics/firebase_analytics_web/lib/interop/analytics_interop.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ external void logEvent(

@JS()
external void setAnalyticsCollectionEnabled(
AnalyticsJsImpl analytics, bool enabled);
AnalyticsJsImpl analytics,
bool enabled,
);

@JS()
external void setCurrentScreen(
Expand All @@ -50,7 +52,7 @@ external void setUserId(
@JS()
external void setUserProperties(
AnalyticsJsImpl analytics,
Map<String, Object?> property,
dynamic property,
AnalyticsCallOptions? callOptions,
);

Expand Down