fix(analytics, web): use jsify with user properties #8852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
packages/firebase_analytics/firebase_analytics_web/lib/interop/analytics_interop.dart Show resolved Hide resolved
russellwheatley approved these changes Jun 15, 2022
Lyokone approved these changes Jun 16, 2022
russellwheatley added a commit that referenced this pull request Jun 28, 2022
* refactor(analytics,web): v9 SDK refactor. * feat(firebase_analytics): provide isSupported for v9/analytics (#8899) * fix(analytics, web): use jsify with user properties (#8852) Co-authored-by: Benjamin Koch <koch@lotum.de> Co-authored-by: Jorge Roncero <60613199+jorgeroncero@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Modify the way Dart sends user properties to native Javascript with the setUserProperties() method. Now using jsify() in the same way that it's used in logEvent() method.
Related Issues
Fixes firebase/flutterfire#8757
Checklist
///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?